Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run coverage on stable rust #279

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

YeungOnion
Copy link
Contributor

No description provided.

@YeungOnion
Copy link
Contributor Author

at the moment, the coverage job for 275 doesn't finish compiling, hangs while reporting Compiling criterion v0.5.1.

Wanting to exclude issues from rustc, using using updated nightly and updated stable compiled the tests on my machine.

Tested here with stable, and the compile passes, next text is doing it on the branch where the issue was seen.

@YeungOnion
Copy link
Contributor Author

stable passes compile for the rand feature as well, trying nightly.

@YeungOnion
Copy link
Contributor Author

YeungOnion commented Sep 9, 2024

reproduced as expected, as this is identical to #275
and of course, revert to master and check nightly on ci, not wanting to miss that just because it worked on my machine.

@YeungOnion
Copy link
Contributor Author

unsure which nightly dtolnay/rust-toolchain uses, but next test is the one that worked locally, nightly-2024-08-29

@YeungOnion
Copy link
Contributor Author

quoted from #268,

Looks like CI is stuck due to rust-lang/rust#130056

Not sure there's much to do about it at the moment. It's just nightly being affected

I'm going to approve this because it compiles on my machine, unless you think I should hold off, I hope within the week the coverage reports will be good again.

@FreezyLemon
Copy link
Contributor

Seems fine.

@YeungOnion YeungOnion merged commit 53e8c97 into statrs-dev:master Sep 10, 2024
6 of 7 checks passed
@YeungOnion YeungOnion deleted the ci/coverage-on-stable-rust branch September 13, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants