Skip to content

Commit

Permalink
_
Browse files Browse the repository at this point in the history
  • Loading branch information
rasom committed Jan 31, 2020
1 parent 4934cca commit 3787d16
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
5 changes: 3 additions & 2 deletions services/ext/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func (s *Service) GetPeer(rawURL string) (*enode.Node, error) {
return enode.ParseV4(rawURL)
}

func (s *Service) InitProtocol(identity *ecdsa.PrivateKey, db *sql.DB) error { // nolint: gocyclo
func (s *Service) InitProtocol(identity *ecdsa.PrivateKey, db *sql.DB, rootDataDir string) error { // nolint: gocyclo
if !s.config.PFSEnabled {
return nil
}
Expand All @@ -131,7 +131,8 @@ func (s *Service) InitProtocol(identity *ecdsa.PrivateKey, db *sql.DB) error { /

s.identity = identity

dataDir := filepath.Clean(s.config.BackupDisabledDataDir)
backupDir := filepath.Join(rootDataDir, s.config.BackupDisabledDataDir)
dataDir := filepath.Clean(backupDir)

if err := os.MkdirAll(dataDir, os.ModePerm); err != nil {
return err
Expand Down
4 changes: 2 additions & 2 deletions services/shhext/api_geth_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ func TestInitProtocol(t *testing.T) {
sqlDB, err := sqlite.OpenDB(fmt.Sprintf("%s/db.sql", tmpdir), "password")
require.NoError(t, err)

err = service.InitProtocol(privateKey, sqlDB)
err = service.InitProtocol(privateKey, sqlDB, "")
require.NoError(t, err)
}

Expand Down Expand Up @@ -264,7 +264,7 @@ func (s *ShhExtSuite) createAndAddNode() {
s.Require().NoError(err)
privateKey, err := crypto.GenerateKey()
s.NoError(err)
err = service.InitProtocol(privateKey, sqlDB)
err = service.InitProtocol(privateKey, sqlDB, "")
s.NoError(err)
err = stack.Register(func(n *node.ServiceContext) (node.Service, error) {
return service, nil
Expand Down
4 changes: 2 additions & 2 deletions services/wakuext/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func TestInitProtocol(t *testing.T) {
sqlDB, err := sqlite.OpenDB(fmt.Sprintf("%s/db.sql", tmpdir), "password")
require.NoError(t, err)

err = service.InitProtocol(privateKey, sqlDB)
err = service.InitProtocol(privateKey, sqlDB, "")
require.NoError(t, err)
}

Expand Down Expand Up @@ -179,7 +179,7 @@ func (s *ShhExtSuite) createAndAddNode() {
s.Require().NoError(err)
privateKey, err := crypto.GenerateKey()
s.NoError(err)
err = service.InitProtocol(privateKey, sqlDB)
err = service.InitProtocol(privateKey, sqlDB, "")
s.NoError(err)
err = stack.Register(func(n *node.ServiceContext) (node.Service, error) {
return service, nil
Expand Down

0 comments on commit 3787d16

Please sign in to comment.