Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for request messages by topics #1805

Merged
merged 8 commits into from
Jan 21, 2020

Conversation

adambabik
Copy link
Contributor

@adambabik adambabik commented Jan 17, 2020

This change adds querying mailservers by topics. It is only supported in waku subprotocol and using PostgreSQL maislerver implementation.

This is the implementation of Waku Mailserver spec v0.2

@status-github-bot
Copy link

status-github-bot bot commented Jan 17, 2020

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented Jan 17, 2020

Jenkins Builds

Click to see older builds (18)
Commit #️⃣ Finished (UTC) Duration Platform Result
eb49894 #1 2020-01-17 15:45:00 ~40 sec android 📄log
✔️ eb49894 #1 2020-01-17 15:45:17 ~54 sec linux 📦zip
eb49894 #1 2020-01-17 15:46:07 ~1 min ios 📄log
✔️ e4c1d13 #2 2020-01-19 17:26:41 ~46 sec linux 📦zip
✔️ e4c1d13 #2 2020-01-19 17:29:47 ~3 min ios 📦zip
✔️ e4c1d13 #2 2020-01-19 17:32:52 ~7 min android 📦aar
✔️ a3a3ff7 #3 2020-01-19 19:39:09 ~43 sec linux 📦zip
✔️ a3a3ff7 #3 2020-01-19 19:41:19 ~2 min ios 📦zip
✔️ a3a3ff7 #3 2020-01-19 19:44:07 ~5 min android 📦aar
0d22dcb #4 2020-01-19 20:21:20 ~23 sec android 📄log
✔️ 0d22dcb #4 2020-01-19 20:21:39 ~38 sec linux 📦zip
✔️ 0d22dcb #4 2020-01-19 20:23:17 ~2 min ios 📦zip
6144adf #5 2020-01-19 20:44:01 ~30 sec ios 📄log
✔️ 6144adf #5 2020-01-19 20:44:09 ~38 sec linux 📦zip
6144adf #5 2020-01-19 20:45:08 ~1 min android 📄log
440b67b #6 2020-01-20 09:18:18 ~21 sec android 📄log
440b67b #6 2020-01-20 09:18:29 ~30 sec ios 📄log
✔️ 440b67b #6 2020-01-20 09:18:42 ~42 sec linux 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7d021f8 #7 2020-01-20 10:05:52 ~46 sec linux 📦zip
✔️ 7d021f8 #7 2020-01-20 10:07:59 ~2 min ios 📦zip
✔️ 7d021f8 #7 2020-01-20 10:11:23 ~6 min android 📦aar
✔️ 1712a9d #8 2020-01-20 21:24:17 ~40 sec linux 📦zip
✔️ 1712a9d #8 2020-01-20 21:26:01 ~2 min ios 📦zip
✔️ 1712a9d #8 2020-01-20 21:29:25 ~5 min android 📦aar

@oskarth
Copy link
Contributor

oskarth commented Jan 20, 2020

Is this PR closing mailserver spec v0.2 (as it currently stands)? Can we make this explicit? https://specs.vac.dev/waku/mailserver.html

@adambabik
Copy link
Contributor Author

@oskarth yes, it does. One question:

  • Do we want to keep it as topic-interest or topics? I guess it does not really matter but I think it would be nice if the implementation align with the field names used in the spec.

@oskarth
Copy link
Contributor

oskarth commented Jan 20, 2020

The spec says topic-interest, do you want to change it? We can, but lets make sure it happens in spec repo first. That way @kdeme can also verify.

@kdeme
Copy link

kdeme commented Jan 20, 2020

I'm ok with the name change. Removes confusion between topic-interest packet and topic-interest parameters.

@adambabik
Copy link
Contributor Author

Spec changes: vacp2p/rfc#91

@adambabik adambabik merged commit bc2d018 into develop Jan 21, 2020
@adambabik adambabik deleted the topics-in-waku-messages-request branch January 21, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants