Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ens names and contact #1810

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Conversation

cammellos
Copy link
Contributor

@cammellos cammellos commented Jan 22, 2020

Currently the wrong pk format was used to query the in-memory contacts,
this commit corrects the behavior.

@status-im-auto
Copy link
Member

status-im-auto commented Jan 22, 2020

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3e335fe #1 2020-01-22 17:41:50 ~1 min linux 📦zip
✔️ 3e335fe #1 2020-01-22 17:46:01 ~5 min ios 📦zip
✔️ 3e335fe #1 2020-01-22 17:48:06 ~7 min android 📦aar
✔️ 348cfd1 #2 2020-01-23 08:00:08 ~46 sec linux 📦zip
✔️ 348cfd1 #2 2020-01-23 08:02:35 ~3 min ios 📦zip
✔️ 348cfd1 #2 2020-01-23 08:04:41 ~5 min android 📦aar

@yenda
Copy link
Contributor

yenda commented Jan 23, 2020

@cammellos is it rebased on latest develop? In which case could you also bump version to 0.39.11 so we merge in status-react along with mailserver fixes?

@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@cammellos cammellos force-pushed the bug/fix-ens-names-and-contacts branch from 3e335fe to 348cfd1 Compare January 23, 2020 07:59
Currently the wrong pk format was used to query the in-memory contacts,
this commit corrects the behavior.
@cammellos cammellos merged commit a4f88d0 into develop Jan 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the bug/fix-ens-names-and-contacts branch January 23, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants