Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to 0.40.0 #1812

Merged
merged 1 commit into from
Jan 23, 2020
Merged

bump to 0.40.0 #1812

merged 1 commit into from
Jan 23, 2020

Conversation

rasom
Copy link
Collaborator

@rasom rasom commented Jan 23, 2020 •
edited by 0xc1c4da
Loading

@adambabik @andremedeiros

There is a breaking change in db schema, should it be 0.40.0 then? Or we keep 0.39.x before release?

@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@rasom rasom requested a review from adambabik January 23, 2020 11:26
@status-im-auto
Copy link
Member

status-im-auto commented Jan 23, 2020 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 411914a #1 2020-01-23 11:26:53 ~45 sec linux 📦zip
✔️ 411914a #1 2020-01-23 11:31:17 ~5 min ios 📦zip
✔️ 411914a #1 2020-01-23 11:32:43 ~6 min android 📦aar
✔️ dc31c81 #2 2020-01-23 12:15:22 ~36 sec linux 📦zip
✔️ dc31c81 #2 2020-01-23 12:17:46 ~3 min ios 📦zip
✔️ dc31c81 #2 2020-01-23 12:20:11 ~5 min android 📦aar

@rasom rasom assigned rasom and unassigned andremedeiros Jan 23, 2020
@cammellos
Copy link
Contributor

It should be 0.40.0 if there's a breaking change, it does not matter so much as I understand this is already tested and ready to go , but any breaking change should bump the 0.x version, likely until we are a bit more stable

@rasom rasom changed the title bump to 0.39.12 bump to 0.40.0 Jan 23, 2020
@rasom
Copy link
Collaborator Author

rasom commented Jan 23, 2020

@cammellos changed to 0.40.0

@rasom rasom merged commit dc31c81 into develop Jan 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the bump-version-0.39.12 branch January 23, 2020 12:33
@weekly-digest weekly-digest bot mentioned this pull request Jan 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammellos cammellos cammellos approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@adambabik adambabik Awaiting requested review from adambabik

@andremedeiros andremedeiros Awaiting requested review from andremedeiros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rasom @status-im-auto @cammellos @flexsurfer @andremedeiros