Use logical clock for ENS #1818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (3)
|
cammellos
force-pushed
the
bug/use-logical-clock-for-ens
branch
2 times, most recently
from
ae86e24
to
58b811d
Compare
Because ENS is pulled from messages, we use a logical clock (clock-value) for ENSVerifiedAt, so that old messages can be handled appropiately. Reduces ticker interval as mobiles are often online for a short period and 2 minutes is too much.
jakubgs
approved these changes
Jan 29, 2020
adambabik
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because ENS is pulled from messages, we use a logical clock
(clock-value) for ENSVerifiedAt, so that old messages can be handled
appropiately.
status: ready