Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform 0.12upgrade #17

Closed
wants to merge 1 commit into from
Closed

terraform 0.12upgrade #17

wants to merge 1 commit into from

Conversation

stavxyz
Copy link
Owner

@stavxyz stavxyz commented Jun 18, 2019

No description provided.

hash_key = "LockID"
stream_enabled = "${var.dynamodb_lock_table_stream_enabled}"
stream_view_type = "${var.dynamodb_lock_table_stream_enabled ? var.dynamodb_lock_table_stream_view_type : ""}"
count = var.dynamodb_lock_table_enabled ? 1 : 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting errors like:


Error: Incorrect attribute value type

  on .terraform/modules/backend/main.tf line 45, in resource "aws_dynamodb_table" "tf_backend_state_lock_table":
  45:   stream_enabled   = var.dynamodb_lock_table_stream_enabled

Inappropriate value for attribute "stream_enabled": bool required.


Error: Incorrect condition type

  on .terraform/modules/backend/main.tf line 46, in resource "aws_dynamodb_table" "tf_backend_state_lock_table":
  46:   stream_view_type = var.dynamodb_lock_table_stream_enabled ? var.dynamodb_lock_table_stream_view_type : ""
    |----------------
    | var.dynamodb_lock_table_stream_enabled is 0

This fixed it richardARPANET@8d90f0c

@stavxyz
Copy link
Owner Author

stavxyz commented Jun 27, 2019

Hey @richardARPANET thanks for the tip.

I suppose all of the boolean-ish options should be changed from 0/1 to real booleans.

@stavxyz
Copy link
Owner Author

stavxyz commented Nov 23, 2019

Closing in favor of #18

@stavxyz stavxyz closed this Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants