-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
card's description of shared boards invisible with read only permission #1635
Comments
I see no error in the app logs. The issue seems similar to this old one : #1401 |
While I haven't been able to reproduce this very issue, I noticed some other issues that are related to the description field and the read only permission. I'll dig into this further within the bext few days. Thank you for your report! |
Hey Stefan, any news on your side? Is there anything we can do to help you to progress on this? |
Not yet, I am currently a bit busy, but I didn't forget you. A Pull Request would of course be welcome, the root cause is probably in this method: https://github.com/stefan-niedermann/nextcloud-deck/blob/master/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java#L151 |
Huh. Actually there might only one line missing in the registerEditorListener(binding.descriptionViewer); |
Thanks, no problem of course! Ok! I'll reed this piece of code and try to see if I feel comfortable with opening a PR (I never tried to play with the dev of a mobile app..!), if you can't find time soon :) Best! |
Refs: #1635 (comment) Signed-off-by: Stefan Niedermann <info@niedermann.it>
Hey, I don't really have the time to set up a proper test environment, but I had enough time to add the line. Here's a DEV build of the app with the above change: APK ԅ(≖‿≖ԅ) You can install the APK right beside your version from F-Droid, you'll end up with an additional deck app with the label "DEV" on the icon. Just connect it to your account, let it sync and then please check if the issue is resolved for you. Looking forward to your feedback! 😊 |
Hi, thanks for those first attempts! I tried both of your builds, the one from the Stefan's PR and the one from your branch desperateCoder, and sadly both of these apparently do not solve the issue. Worse, the title disappeared too 😅 But maybe it's a clue? Note that we don't use the tags, neither the assign, nor the due date, so I don't know for those elements |
This issue respects the following points:
Describe the bug
plop
and share it with user B, with read-only permissionplop
and open a cardDescription is invisible (attachments, comments and activity are visible) - the bug is reproducible for all concerned users
Expected behavior
Description is visible (as in the web browser app)
Deck Android version
1.24.1
Deck server version
1.13.0
Nextcloud Android version
3.29.0
Nextcloud version
29.0.1
Device
Galaxy A5 2017 (reproduced on multiple devices)
Android Version
11
App Store
Stacktrace
No response
The text was updated successfully, but these errors were encountered: