WIP: Editing #25
WIP: Editing #25
Conversation
stefan-niedermann
commented
Dec 11, 2018
•
stefan-niedermann
commented
|
Hi @stefan-niedermann @desperateCoder how would we want to integrate this? Of course all this can be done at a far later point in time :) |
The contacts app is a bit different, since all contact details have a individual actio (like call a number). The only action we have is the editing one, so I think inline editing would be the best mode here. In general having the details in a view pager makes sense to me. (Note that we might merge the duedate/assigned users/... entries to the first tab in the web ui as well during the sidebar standardization for 16) |
sounds good to me
So all the actual tabs in the webUI will remain? What would be the content and name/icon of the then to be created tab you plan to do for Nc16? |
|
@AndyScherzinger The standardization issue is here nextcloud/server#10289 It basically reduces the tabs to Details, Sharing, Activity I still need to do some thinking about how we handle that in deck, since sharing doesn't make a lot of sense on cards. But we will probably end up with
|
|
@juliushaertl @stefan-niedermann see latest screenshot, added tabs for the details screen :) |
|
Looks pretty nice already. 👍 |
|
Indeed :) We could put the modified and created date as a subheader into the action bar, i am not sure how important it is. Also personally i think the description might be more important than the other stuff (put it on top??) |
|
No real idea about the ordering to be honest. I'd say we should maybe try to keep it in the order the webUI uses (not sure about the actual order) while like with the tabs I think it would be nice to already implement it the way @juliushaertl plans to implement it in the upcoming versions. Information designers to the rescue please :) |
|
The creation and modification dates could probably go into the toolbar, sure. They can't be explicitly changed anyways :) |
|
The title "Edit" should have a more relevant label. :) Like the card name. And for new cards, say "New card in |
…-deck into room # Conflicts: # app/src/main/java/it/niedermann/nextcloud/deck/ui/card/CardAdapter.java
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
former behavior: when clicking on description, keyboard appeared and description was no longer visible on screen. It's a quick fix and should be properly done in the future ;)
# Conflicts: # app/src/main/java/it/niedermann/nextcloud/deck/ui/card/CardDetailsFragment.java # app/src/main/res/layout/activity_edit.xml # app/src/main/res/layout/fragment_card_edit_tab_details.xml
```
3-12 09:53:47.234 2271-2271/it.niedermann.nextcloud.deck E/AndroidRuntime: FATAL EXCEPTION: main
android.content.res.Resources$NotFoundException: File res/drawable/ic_view_column_black_24dp.xml from drawable resource ID #0x7f07007b. If the resource you are trying to use is a vector resource, you may be referencing it in an unsupported way. See AppCompatDelegate.setCompatVectorFromResourcesEnabled() for more info.
at android.content.res.Resources.loadDrawable(Resources.java:1928)
at android.content.res.Resources.getDrawable(Resources.java:664)
at androidx.core.content.ContextCompat.getDrawable(ContextCompat.java:479)
at it.niedermann.nextcloud.deck.ui.MainActivity.buildSidenavMenu(MainActivity.java:187)
at it.niedermann.nextcloud.deck.ui.MainActivity.access$100(MainActivity.java:45)
at it.niedermann.nextcloud.deck.ui.MainActivity$1.lambda$null$0(MainActivity.java:157)
at it.niedermann.nextcloud.deck.ui.-$$Lambda$MainActivity$1$fjUtebZdN0tro2_UplyAlWSvn7E.onChanged(lambda)
at androidx.lifecycle.LiveData.considerNotify(LiveData.java:113)
at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:131)
at androidx.lifecycle.LiveData.setValue(LiveData.java:289)
at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:33)
at androidx.lifecycle.LiveData$1.run(LiveData.java:91)
at android.os.Handler.handleCallback(Handler.java:605)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:4424)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
at dalvik.system.NativeStart.main(Native Method)
Caused by: org.xmlpull.v1.XmlPullParserException: Binary XML file line #1: invalid drawable tag vector
at android.graphics.drawable.Drawable.createFromXmlInner(Drawable.java:863)
at android.graphics.drawable.Drawable.createFromXml(Drawable.java:804)
at android.content.res.Resources.loadDrawable(Resources.java:1925)
at android.content.res.Resources.getDrawable(Resources.java:664)
at androidx.core.content.ContextCompat.getDrawable(ContextCompat.java:479)
at it.niedermann.nextcloud.deck.ui.MainActivity.buildSidenavMenu(MainActivity.java:187)
at it.niedermann.nextcloud.deck.ui.MainActivity.access$100(MainActivity.java:45)
at it.niedermann.nextcloud.deck.ui.MainActivity$1.lambda$null$0(MainActivity.java:157)
at it.niedermann.nextcloud.deck.ui.-$$Lambda$MainActivity$1$fjUtebZdN0tro2_UplyAlWSvn7E.onChanged(lambda)
at androidx.lifecycle.LiveData.considerNotify(LiveData.java:113)
at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:131)
at androidx.lifecycle.LiveData.setValue(LiveData.java:289)
at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:33)
at androidx.lifecycle.LiveData$1.run(LiveData.java:91)
at android.os.Handler.handleCallback(Handler.java:605)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:4424)
```
Same way that the files app handles create-operation
