This repository has been archived by the owner on May 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add custom reporter to produce Problem Matcher output #2
Open
stefanbuck
wants to merge
5
commits into
master
Choose a base branch
from
add-custom-reporter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8245003
Add custom reporter to produce Problem Matcher ouput
stefanbuck 6cb8f1e
update test
stefanbuck 56a75b4
Do not rely on test location to get line number
stefanbuck 42c3323
Loop all the arrays
stefanbuck 82d50fd
more tests
stefanbuck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Do not rely on test location to get line number
- Loading branch information
commit 56a75b417c258b93a263b9a122e33701839a91b4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,15 +12,8 @@ class MyCustomReporter { | |
const newLine = "%0A"; | ||
const name = results.testResults[0].testFilePath; | ||
|
||
if (!item.location) { | ||
throw new Error( | ||
"You need to invoked jest with argument --testLocationInResults" | ||
); | ||
} | ||
|
||
const line = item.location.line + 1; | ||
const col = item.location.column; | ||
const message = item.failureMessages[0].replace(/\n/g, newLine); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We might need to iterate over |
||
const [, line, col] = item.failureMessages[0].match(/:([0-9]+):([0-9]+)/); | ||
|
||
console.log(`::error file=${name},line=${line},col=${col}::${message}`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The GitHub runner has some build in matchers and therefore all we have to do is producing output in this format actions/toolkit#260 (comment) |
||
}); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to url encode new lines in order to produce a matcher message that can spawn over multiple lines