Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dependabot with GitHub Action #356

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Replace dependabot with GitHub Action #356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e346c6f
Replace dependabot with GitHub Action
quietbits Oct 15, 2021
6a6c9f9
Use commit SHA instead of tag
quietbits Oct 15, 2021
f42a527
Update issue description
quietbits Oct 18, 2021
518852d
Merge branch 'il-deps-gh-action' of github.com:stellar/account-viewer…
quietbits Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/dependabot.yml
View file
Open in desktop

This file was deleted.

26 changes: 26 additions & 0 deletions .github/workflows/update_deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Monthly dependency updates
on:
schedule:
# First of every month
- cron: 0 0 1 * *

jobs:
create_issue:
name: Update dependencies
runs-on: ubuntu-latest
permissions:
issues: write
steps:
- name: Update dependencies
uses: imjohnbo/issue-bot@v3.3.4
quietbits marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ GitHub had a list of things they recommend we do whenever using third party actions:

  • Pin actions to a full length commit SHA

  • Audit the source code of the action

  • Pin actions to a tag only if you trust the creator

Ref: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

Can you do the first two items?

with:
title: "Update dependencies"
body: |
Update all project dependencies
```
yarn upgrade-interactive --latest
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Do you have a checklist of things you do for the upgrade that we could knowledge share here? Also, it might be helpful to include commands for how you look at diffs of dependencies being upgraded, so everyones process converges for how to do this.

pinned: false
close-previous: false
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}