Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump trezor-connect to 8.2.4-extended #366

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Dec 13, 2021

We need to upgrade to the latest version to ensure that the signature is correct, please check this issue(trezor/connect#970) for details.

I'm still waiting for an update from the Trezor team, will mark this PR as ready later.

@overcat overcat marked this pull request as ready for review December 13, 2021 15:29
package.json Show resolved Hide resolved
@overcat
Copy link
Contributor Author

overcat commented Dec 13, 2021

Hi @quietbits, I tested it with a real Trezor device and it seems to work well. If there are no other problems, I think this and stellar/laboratory#625 should be deployed to the production environment as soon as possible.

Copy link
Contributor

@quietbits quietbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! 🙌 Let's wait for the PR preview to make sure it works as expected. Looks like we don't do PR previews on forks. I'll test it locally now.

package.json Show resolved Hide resolved
@overcat
Copy link
Contributor Author

overcat commented Dec 13, 2021

@quietbits please check the comment trezor/connect#970 (comment)

@quietbits
Copy link
Contributor

Ahh, I see. With -extended we get plugins folder and don't need to have the Trezor transform file locally. That's great, thanks @overcat !

@quietbits
Copy link
Contributor

@overcat worked for me locally with the latest Trezor One firmware. 🎉 Good to merge.

@overcat overcat changed the title bump trezor-connect to ^8.2.4 bump trezor-connect to 8.2.4-extended Dec 13, 2021
@quietbits quietbits merged commit 4058b58 into stellar:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants