Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing type for TransactionBuilder.TransactionBuilderOptions.networkPassphrase #237

Closed
rm4n0s opened this issue Aug 3, 2019 · 2 comments
Assignees
Labels

Comments

@rm4n0s
Copy link

rm4n0s commented Aug 3, 2019

Describe the bug
Using typescript with the latest version of stellar-sdk, I can not disable a message, because it does not compile the attribute 'networkPassphrase'

This is the message

Global class Network is deprecated. Please pass explicit argument instead, e.g. new Transaction(envelope, Networks.PUBLIC) (see https://git.io/fj9fG for more info).

What version are you on?
Running stellar-base v1.1.0

To Reproduce
Try an example that uses TransactionBuilder in Typescript with the attribute networkPassphrase to Networks.TESTNET and try to compile it

Expected behavior
It will not compile.

@rm4n0s rm4n0s added the bug label Aug 3, 2019
@abuiles abuiles self-assigned this Aug 5, 2019
@abuiles
Copy link
Contributor

abuiles commented Aug 5, 2019

@mragiadakos thanks for the report! We'll push a new release soon to fix this.

@abuiles
Copy link
Contributor

abuiles commented Aug 5, 2019

@mgreville a fix for this has been merged and is now available in 1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants