Fix test and make all related args a string.

src/transaction_builder.js

@@ -17,7 +17,7 @@ import { Memo } from './memo';
  * @constant
  * @see [Fees](https://www.stellar.org/developers/guides/concepts/fees.html)
  */
-export const BASE_FEE = 100; // Stroops
+export const BASE_FEE = '100'; // Stroops
 
 /**
  * @constant
@@ -70,7 +70,7 @@ export const TimeoutInfinite = 0;
  * @constructor
  * @param {Account} sourceAccount - The source account for this transaction.
  * @param {object} opts Options object
- * @param {number} opts.fee - The max fee willing to pay per operation in this transaction (**in stroops**). Required.
+ * @param {string} opts.fee - The max fee willing to pay per operation in this transaction (**in stroops**). Required.
  * @param {object} [opts.timebounds] - The timebounds for the validity of this transaction.
  * @param {number|string|Date} [opts.timebounds.minTime] - 64 bit unix timestamp or Date object
  * @param {number|string|Date} [opts.timebounds.maxTime] - 64 bit unix timestamp or Date object
@@ -188,8 +188,11 @@ export class TransactionBuilder {
    */
   build() {
     const sequenceNumber = new BigNumber(this.source.sequenceNumber()).add(1);
+    const fee = new BigNumber(this.baseFee)
+      .mul(this.operations.length)
+      .toNumber();
     const attrs = {
-      fee: this.baseFee * this.operations.length,
+      fee,
       seqNum: xdr.SequenceNumber.fromString(sequenceNumber.toString()),
       memo: this.memo ? this.memo.toXDRObject() : null
     };

test/unit/transaction_builder_test.js

@@ -53,7 +53,7 @@ describe('TransactionBuilder', function() {
     });
 
     it('should have 100 stroops fee', function(done) {
-      expect(transaction.fee).to.be.equal(100);
+      expect(transaction.fee).to.be.equal('100');
       done();
     });
   });
@@ -120,7 +120,7 @@ describe('TransactionBuilder', function() {
     });
 
     it('should have 200 stroops fee', function(done) {
-      expect(transaction.fee).to.be.equal(200);
+      expect(transaction.fee).to.be.equal('200');
       done();
     });
   });
@@ -165,7 +165,7 @@ describe('TransactionBuilder', function() {
     });
 
     it('should have 2000 stroops fee', function(done) {
-      expect(transaction.fee).to.be.equal(2000);
+      expect(transaction.fee).to.be.equal('2000');
       done();
     });
   });
@@ -260,8 +260,8 @@ describe('TransactionBuilder', function() {
       done();
     });
   });
-  describe('timebounds', function(){
-    it('requires maxTime', function(){
+  describe('timebounds', function() {
+    it('requires maxTime', function() {
       let source = new StellarBase.Account(
         'GCEZWKCA5VLDNRLN3RPRJMRZOX3Z6G5CHCGSNFHEYVXM3XOJMDS674JZ',
         '0'
@@ -273,9 +273,11 @@ describe('TransactionBuilder', function() {
           },
           fee: 100
         }).build();
-      }).to.throw('TimeBounds has to be set or you must call setTimeout(TimeoutInfinite).');
+      }).to.throw(
+        'TimeBounds has to be set or you must call setTimeout(TimeoutInfinite).'
+      );
     });
-    it('requires minTime', function(){
+    it('requires minTime', function() {
       let source = new StellarBase.Account(
         'GCEZWKCA5VLDNRLN3RPRJMRZOX3Z6G5CHCGSNFHEYVXM3XOJMDS674JZ',
         '0'
@@ -287,9 +289,11 @@ describe('TransactionBuilder', function() {
           },
           fee: 100
         }).build();
-      }).to.throw('TimeBounds has to be set or you must call setTimeout(TimeoutInfinite).');
+      }).to.throw(
+        'TimeBounds has to be set or you must call setTimeout(TimeoutInfinite).'
+      );
     });
-    it('works with timebounds defined', function(){
+    it('works with timebounds defined', function() {
       let source = new StellarBase.Account(
         'GCEZWKCA5VLDNRLN3RPRJMRZOX3Z6G5CHCGSNFHEYVXM3XOJMDS674JZ',
         '0'
@@ -304,7 +308,7 @@ describe('TransactionBuilder', function() {
         }).build();
       }).to.not.throw();
     });
-    it('fails with empty timebounds', function(){
+    it('fails with empty timebounds', function() {
       let source = new StellarBase.Account(
         'GCEZWKCA5VLDNRLN3RPRJMRZOX3Z6G5CHCGSNFHEYVXM3XOJMDS674JZ',
         '0'
@@ -314,7 +318,9 @@ describe('TransactionBuilder', function() {
           timebounds: {},
           fee: 100
         }).build();
-      }).to.throw('TimeBounds has to be set or you must call setTimeout(TimeoutInfinite).');
+      }).to.throw(
+        'TimeBounds has to be set or you must call setTimeout(TimeoutInfinite).'
+      );
     });
   });
   describe('setTimeout', function() {
@@ -440,15 +446,17 @@ describe('TransactionBuilder', function() {
         timeoutTimestamp.toString()
       );
     });
-    it('works with TimeoutInfinite', function(){
+    it('works with TimeoutInfinite', function() {
       let source = new StellarBase.Account(
         'GCEZWKCA5VLDNRLN3RPRJMRZOX3Z6G5CHCGSNFHEYVXM3XOJMDS674JZ',
         '0'
       );
       expect(() => {
         new StellarBase.TransactionBuilder(source, {
           fee: 100
-        }).setTimeout(0).build();
+        })
+          .setTimeout(0)
+          .build();
       }).to.not.throw();
     });
   });

test/unit/transaction_test.js

@@ -31,7 +31,7 @@ describe('Transaction', function() {
     var operation = transaction.operations[0];
 
     expect(transaction.source).to.be.equal(source.accountId());
-    expect(transaction.fee).to.be.equal(100);
+    expect(transaction.fee).to.be.equal('100');
     expect(transaction.memo.type).to.be.equal(StellarBase.MemoText);
     expect(transaction.memo.value.toString('ascii')).to.be.equal(
       'Happy birthday!'
@@ -440,7 +440,7 @@ describe('Transaction', function() {
     );
     var operation = transaction.operations[0];
 
-    expect(transaction.fee).to.be.equal(0);
+    expect(transaction.fee).to.be.equal('0');
 
     done();
   });

types/index.d.ts

@@ -536,7 +536,7 @@ export class Transaction<
   };
 }
 
-export const BASE_FEE = 100;
+export const BASE_FEE = "100";
 export const TimeoutInfinite = 0;
 
 export class TransactionBuilder {
@@ -553,7 +553,7 @@ export class TransactionBuilder {
 
 export namespace TransactionBuilder {
   interface TransactionBuilderOptions {
-    fee: number;
+    fee: string;
     timebounds?: {
       minTime?: number | string;
       maxTime?: number | string;