Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade XDR to Protocol 21 #738

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Upgrade XDR to Protocol 21 #738

merged 5 commits into from
Apr 26, 2024

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Apr 25, 2024

This updates the XDR to stellar/stellar-xdr@1a04392.

Copy link

Size Change: +13.6 kB (0%)

Total Size: 3.21 MB

Filename Size Change
dist/stellar-base.js 2.36 MB +11.1 kB (0%)
dist/stellar-base.min.js 855 kB +2.5 kB (0%)

compressed-size-action

@@ -14,7 +14,7 @@ XDR_FILES_CURR= \
Stellar-contract-config-setting.x
XDR_FILES_LOCAL_CURR=$(addprefix xdr/curr/,$(XDR_FILES_CURR))

XDR_BASE_URL_NEXT=https://github.com/stellar/stellar-xdr/raw/bb54e505f814386a3f45172e0b7e95b7badbe969
XDR_BASE_URL_NEXT=https://github.com/stellar/stellar-xdr/raw/4bd4827b3361f266d295cbc83c5d7f7396d782d9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to bump the 'next' codeline in this pr scope, seems the intent is to just change the xdr version for client usage which is 'curr' ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I guess technically not but there is no harm either in case someone wanted to use the SDK to dev on next for whatever reason 🤷 imo it's nice to keep them updated at the same time

Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all this gen'd code looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants