Comparison fixes #762
Merged
Comparison fixes #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Three patches toward making
Compare<RawVal> for EnvandCompare<ScVal> for Budgetbehave identically toOrd for ScVal, per #743.These are the initial patches described in my comment here: #743 (comment)
Why
As discussed in that issue, all three of
Compare<RawVal> for Env,Compare<ScVal> for BudgetandOrd for ScValneed to behave the same. These patches fix the first three discrepancies I have found through fuzzing.Known limitations
This adds some hand-written unit tests to prevent regressions, but I intend to add comprehensive proptests / fuzz tests to the soroban-sdk crate eventually. Such tests depend on some fuzzing-related patches that are not yet ready to land.