Favor stellar config dir. #1681
Open
+65
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifropc
reviewed
Oct 18, 2024
| ); | ||
|
|
||
| if (locator.global && dirname == "soroban") || (!locator.global && dirname == ".soroban") { | ||
| printer.warnln(message); |
There was a problem hiding this comment.
Should we do it automatically? This config directory is created and managed by the cli
| let soroban_dir = config_dir.join("soroban"); | ||
| let stellar_dir = config_dir.join("stellar"); | ||
|
|
||
| if soroban_dir.exists() { |
There was a problem hiding this comment.
If both exists, IMO we should either use stellar_dir first or return an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Favor
~/.config/stellarandpwd/.stellarconfig directories. This will create missing config dirs by using the stellar name, instead of soroban. There's also a check to let users know that the preferred name is now stellar.Why
Given the push to the stellar-cli, we're should match config directories as well. Right now, we already have checks for local .stellar config directories, even though we generate a
.sorobanin case it doesn't exist.Known limitations
N/A