build: CI test generated TS libraries #905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What ---- Add CI test to run the tests in cmd/crates/soroban-spec-typescript/ts-tests Why --- This will ensure that the generated typescript libraries continue to work as they should.
|
I'm not seeing the bindings CI test, do you need special permission to run the new action? |
chadoh
force-pushed
the
feat/test-generated-libs
branch
from
758f29e
to
8e1aceb
Compare
chadoh
commented
Aug 28, 2023
Comment on lines
+5
to
+12
| "postinstall": "curl -X POST \"http://localhost:8000/soroban/rpc\" && npm run fund && npm run deploy && npm run bindings || { echo \"Make sure you're running standalone RPC network on localhost:8000\" && exit 1; }", | ||
| "fund": "./soroban config identity fund", | ||
| "bindings:custom-types": "./soroban contract bindings typescript --contract-id $(cat contract-id-custom-types.txt) --output-dir ./node_modules/test-custom-types --overwrite", | ||
| "bindings:hello-world": "./soroban contract bindings typescript --contract-id $(cat contract-id-hello-world.txt) --output-dir ./node_modules/test-hello-world --overwrite", | ||
| "bindings": "npm run bindings:custom-types && npm run bindings:hello-world", | ||
| "deploy:custom-types": "(./soroban contract deploy --wasm ../../../../target/wasm32-unknown-unknown/test-wasms/test_custom_types.wasm) > contract-id-custom-types.txt", | ||
| "deploy:hello-world": "(./soroban contract deploy --wasm ../../../../target/wasm32-unknown-unknown/test-wasms/test_hello_world.wasm) > contract-id-hello-world.txt", | ||
| "deploy": "npm run deploy:custom-types && npm run deploy:hello-world", |
There was a problem hiding this comment.
Notice that this now adds CI tests for the networked versions of CLI commands contract bindings and contract deploy directly to the soroban-tools repo, rather than needing system-test for these tests.
If we also add a simple invoke test, then we'll have duplicated system-test with a more-reliable, more-maintainable, three-minutes-to-run CI workflow.
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
|
Obsolesced by #1037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add CI test to run the tests in cmd/crates/soroban-spec-typescript/ts-tests
Why
This will ensure that the generated typescript libraries continue to work as they should.
Known limitations
N/A