Fix/ignore phpcs on tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redscar
reviewed
Jun 18, 2024
.github/workflows/phpcs.yml
Outdated
| @@ -66,4 +66,24 @@ jobs: | |||
| env: | |||
| REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.access-token }} | |||
| run: | | |||
| vendor/bin/phpcs --report=json ${CHANGED_FILES} | jq -r ' .files | to_entries[] | .key as $path | .value.messages[] as $msg | "\($path):\($msg.line):\($msg.column):`\($msg.source)`<br>\($msg.message)" ' | reviewdog -efm="%f:%l:%c:%m" -name="phpcs" -filter-mode="added" -fail-on-error=true -reporter=github-pr-review | |||
| # Run phpcs and capture both the output and the exit code | |||
| JSON_REPORT=$(vendor/bin/phpcs --report=json src/Tribe/Main.php || echo "") | |||
There was a problem hiding this comment.
Suggested change
| JSON_REPORT=$(vendor/bin/phpcs --report=json src/Tribe/Main.php || echo "") | |
| JSON_REPORT=$(vendor/bin/phpcs --report=json ${CHANGED_FILES} || echo "") |
redscar
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Looks great.
When the code has issues the PHPCS test fails properly.
When the code has been fixed PHPCS test passes.
Tested on https://github.com/the-events-calendar/events-community/pull/695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail non silently. Catch phpcs exit code and exit with that one.
Also check if the json report produced is valid json and if not
exit 1Please ignore the trial and error i had in the branch. Couldn't figure out where it was failing until the only possibility was
phpcs's exit code