Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: multisite token logic #51

Draft
wants to merge 100 commits into
base: main
Choose a base branch
from
Draft

Conversation

defunctl
Copy link
Contributor

@defunctl defunctl commented Dec 1, 2023

Main Changes

This PR completely changes the way Uplink treats multisite installations. See the new multisite licensing documentation.

  • All token storing/disconnecting logic now requires a Resource slug in order to test whether the plugin is network activated or not, so we know where to store the token.
  • Lots of new helper functions to provide a common interface for accessing Uplink functionality.

Other

  • Fixes failing Replacement_Key tests due to renaming of base API url.

@defunctl defunctl self-assigned this Dec 1, 2023
@defunctl defunctl added the bug Something isn't working label Dec 1, 2023
@defunctl defunctl added this to the 2.0.0 milestone Dec 6, 2023
defunctl and others added 23 commits January 9, 2024 15:25
…-logic

Bugfix: Use unique actions for each resource slug for token connect/disconnect
…use-plugin-slug

Make authorized checks require a plugin slug
…te-token-logic

# Conflicts:
#	.github/workflows/tests-php.yml
@@ -210,6 +210,9 @@ public function inject_info( $result, ?string $action = null, $args = null ) {
if ( ! $relevant ) {
return $result;
}
if ( apply_filters( 'stellarwp/uplink/' . $args->slug . '/prevent_update_check', false ) ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a line break!

Suggested change
if ( apply_filters( 'stellarwp/uplink/' . $args->slug . '/prevent_update_check', false ) ) {
if ( apply_filters( 'stellarwp/uplink/' . $args->slug . '/prevent_update_check', false ) ) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants