Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd hashtag search results #1405

Closed
cspotcode opened this issue May 20, 2024 · 5 comments · Fixed by #1477
Closed

Odd hashtag search results #1405

cspotcode opened this issue May 20, 2024 · 5 comments · Fixed by #1477
Assignees
Labels
bug Something isn't working released Available in a released installer

Comments

@cspotcode
Copy link

Problem to Solve

Adding hashtags, searching for pairs of hashtags, and re-scanning while re-submitting my search query to see updated results, seems to get search results into a confusing state.

I've created 4 lines with different combinations of hashtags on a page, shown in screenshot below. At first I tried searching for #foo #bar to verify that search would only show me the line with both hashtags, not the lines with a single hashtag.

Then I added the line with #baz, re-ran the scan, and searched for #baz. This screenshot shows the search results. The red arrows show which paragraph is highlighted when clicking each search result.

To Reproduce

Steps to reproduce the behavior:

  1. Add to a document:
#foo
#bar
#foo bar
  1. Scan for hashtags.
  2. Search for #foo #bar
  3. Append to document:
#baz
  1. Scan for hashtags.
  2. Search for #baz

Expected Behavior

I was hoping that searching for #foo #bar would show a single search result: the paragraph with both hashtags #foo and #bar.

I expected that searching for #baz would show a single search result: the paragraph with the hashtag #baz.

I expected that the hashtags shown in search results would match those on the page. But instead I see the link to the #bar paragraph showing #foo #bar in the search results pane.

Screenshots

image

Environment (if applicable)

  • OneNote Version: O365 64bit 16.0.17531.20152
  • OneMore Version 6.3.1

Additional Context

Add any other context about the problem here. Attach page XML file or the app log file as appropriate. You can find the log file here: %localappdata%\temp\OneMore.log

THE FINE PRINT This is a hobby project that I started for myself. I'm happy to take requests and will promise to
consider each one carefully but offer no guarantees that I will ultimately agree to their
usefulness or have time to implement any of them. If OneNote offers a "close enough" work-around
then I will probably reject the request - you've been warned!

@cspotcode cspotcode added bug Something isn't working unread I have seen it or had time to refine it yet labels May 20, 2024
@cspotcode
Copy link
Author

This might be two bugs in one issue, and sorry the issue title isn't more descriptive, I wasn't entirely sure how to describe this behaviour.

@stevencohn
Copy link
Owner

stevencohn commented May 20, 2024

I'm unable to reproduce the mismatched links to paragraphs but otherwise, it's working as intended.

Hashtags and searching for them is described on the onemoreaddin.com wiki here.

Searching for #foo #bar is the same as #foo and #bar. You can use the or operator as well.

When it finds a page with your hashtags, it will also show all other hashtags on that page. It highlights direct hits in blue and "other" hashtags in gray, making it easy to find associations.

@stevencohn stevencohn added need-more-info Need more info from user before proceeding and removed unread I have seen it or had time to refine it yet labels May 20, 2024
@stevencohn
Copy link
Owner

Hi @cspotcode, aside from possibly being able to order the sub-results better (showing inline sub-results in document-order), I'm unable to reproduce what you show in your screenshot - multiple sub-results of "#foo #bar" pointing to lines that don't have either #foo or #bar.

image

Please let me know if this is still an ongoing issue or if you have further steps that might help clarify how to reproduce. Thanks!

@cspotcode
Copy link
Author

cspotcode commented Jul 13, 2024 via email

@stevencohn
Copy link
Owner

I'll keep it open to look into the ordering of sub-items. Thanks!

@stevencohn stevencohn removed the need-more-info Need more info from user before proceeding label Jul 13, 2024
stevencohn added a commit that referenced this issue Jul 14, 2024
stevencohn added a commit that referenced this issue Jul 14, 2024
* Capture tags in document order
#1405

* rewrite tags to reestablish full doc order amonst all
#1405
@stevencohn stevencohn self-assigned this Jul 14, 2024
@stevencohn stevencohn added the next-release Addressed but not yet released label Jul 14, 2024
@stevencohn stevencohn linked a pull request Jul 14, 2024 that will close this issue
weissm pushed a commit to weissm/OneMore that referenced this issue Jul 15, 2024
* Capture tags in document order
stevencohn#1405

* rewrite tags to reestablish full doc order amonst all
stevencohn#1405
weissm pushed a commit to weissm/OneMore that referenced this issue Jul 15, 2024
* Capture tags in document order
stevencohn#1405

* rewrite tags to reestablish full doc order amonst all
stevencohn#1405
@stevencohn stevencohn added released Available in a released installer and removed next-release Addressed but not yet released labels Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in a released installer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants