Return response after update #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Can you add this change in the Changelog? |
Right now it's impossible to do anything with the response from onUpdate() when subclassing. I'd like to be able to examine the response object and take further actions depending on the result. To make this possible, I've returned the response, which I think should make it possible to use it if needed.
|
@guillaumebriday Done! ✅ |
|
Sorry to bump this @guillaumebriday but can this be merged and released? 🙏 |
|
Thanks @iainbeeston Available here https://github.com/stimulus-components/stimulus-sortable/releases/tag/v4.1.1 Let met know if everything is working properly for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's impossible to do anything with the response from onUpdate() when subclassing. I'd like to be able to examine the response object and take further actions depending on the result.
To make this possible, I've returned the response, which I think should make it possible to use it if needed.