-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotenv (.env) not supported correctly #201
Comments
Hi, this should now work correctly if you have a dotenv language extension installed in VSCode, eg mikestead.dotenv (I just tried it myself) |
Do you have the mikestead.dotenv extension installed? |
Yep
No errors appear when rewrapping. One note: I am running this through ssh remote workspace. However everything else seems to work fine. |
Ok I think that's why it's not finding the extension. Any chance you can test it just locally? |
It does work locally, I guess the issue really is on Saying that though I haven't looked into the source for rewrap so I can't make assumptions on how it structures what is and what isn't a comment. Any workarounds that you know of or just kind of stuck waiting for |
On the note of installed extensions, does vscode not abstract away a list of installed extensions regardless if they're loaded on the client or the server it's connected to? I would have thought they merged at one point. |
Wasn't being detected as a UI extension by VSCode, so when working with remote workspaces, it would have to be installed into the remote workspace. This also meant that other locally-installed language extensions weren't being found (vscode.extensions.all didn't contain them?) causing issue #201, which should be fixed by this. The option for it to be installed as a workspace extension is still available but not sure if it should be, and where this would be necessary.
@aschmois VSCode provides a list of installed extensions; and while I'm not certain, I think that for extensions installed on the server the list would be only the other extensions installed on the server. Even if it were for all extensions, Rewrap needs access to the Dotenv extension's files, which it won't have if it's installed on the server and the Dotenv extension on the client. However thankfully I think the problem has been easily solved by declaring Rewrap as a UI extension (#231), so it shouldn't be installed on the server in the first place. This change is in the next version (and the current beta version). |
Fixed in v1.14.0 |
Comments inside of a dotenv file don't wrap correctly. When wrapping a line the
#
is not added automatically. And sometimes will try to wrap non commented lines as well.The text was updated successfully, but these errors were encountered: