Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONObject map type unit tests #685

Merged
merged 1 commit into from
Aug 23, 2022
Merged

JSONObject map type unit tests #685

merged 1 commit into from
Aug 23, 2022

Conversation

stleary
Copy link
Owner

@stleary stleary commented Aug 20, 2022

What problem does this code solve?
Set up unit tests for user-managed JSONObject map type. Ensure that all methods result in a JSONObject map type that matches the one created in the default constructor.

Risks
Low

Changes to the API?
Added a getMapType() method to JSONObject

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
A few unit tests were adjusted to make it easier to test multiple JSONObject and JSONArray instances.

Review status
APPROVED - by myself

@stleary
Copy link
Owner Author

stleary commented Aug 20, 2022

Starting a 3 day comment window

@stleary stleary merged commit 5a587bb into master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant