Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes possible unit test bug when compiling/testing on Windows #752

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

davejbur
Copy link

Issue537.xml file must be read as UTF-8 (#745).
Otherwise, on Windows, the test fails - the beta character (U+03B2) gets read as the two ascii characters 206 & 178.

@stleary
Copy link
Owner

stleary commented Jun 26, 2023

What problem does this code solve?
Unit test might fail when running on Windows

Risks
Low

Changes to the API?
N/A

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
Fixes a potential problem in unit tests

Was any code refactored in this commit?
N/A

Review status
APPROVED

@stleary
Copy link
Owner

stleary commented Jun 26, 2023

Starting 3-day comment window

@stleary stleary merged commit 8ce0019 into stleary:master Jun 29, 2023
@stleary stleary changed the title Correction of bug when compiling/testing on Windows Fixes possible unit test bug when compiling/testing on Windows Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants