Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows - in the test #782

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

mureinik
Copy link
Contributor

@mureinik mureinik commented Oct 5, 2023

XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig fails when run on Windows due to mismatching linebreaks (that aren't important for the test's functionality) between the actual and expected strings.

For the actual strings, linebreaks are canonized to the platform's native linebreak using replaceAll("\\n|\\r\\n", System.getProperty("line.separator"). However, the expected result is read from a file, and is left with the linebreaks that were originally used to create it.

The solution is to perform the same canonization on both strings.

Closes #781

XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig fails
when run on Windows due to mismatching linebreaks (that aren't
important for the test's functionality) between the actual and
expected strings.

For the actual strings, linebreaks are canonized to the platform's
native linebreak using `replaceAll("\\n|\\r\\n",
System.getProperty("line.separator")`. However, the expected result is
read from a file, and is left with the linebreaks that were originally
used to create it.

The solution is to perform the same canonization on both strings.

Closes stleary#781
@stleary stleary changed the title Fix XMLTest on Windows Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows Oct 5, 2023
Use the built-in System.lineSeparator() instead of implementing it
ourselves with System.getProperty("line.separator") in order to clean
up the code and make it easier to maintain.
@stleary
Copy link
Owner

stleary commented Oct 6, 2023

What problem does this code solve?
Fixes a unit test that somehow became broken in Windows

Risks
Low

Changes to the API?
N/A

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
N/A

Was any code refactored in this commit?
N/A

Review status
APPROVED

Starting 3-day comment window

@stleary stleary changed the title Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows - in the test Oct 6, 2023
@stleary stleary merged commit bc09f90 into stleary:master Oct 8, 2023
5 checks passed
@mureinik mureinik deleted the XMLTest-windows branch October 9, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig fails on Windows
3 participants