Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This random number generator was used in a way that made it twice as likely to roll the highest number for any given die as any other number for that die.
The code
:crypto.rand_uniform(0, n+1)
increases the range of the uniform random number generator one higher than intended. The range extends from0
up to and includingnum_sides
.So,
Enum.at(die, index - 1)
would give the highest result ifindex
was zero. It would also give the highest result ifindex
wasnum_sides
. This would make the highest result twice as likely as any other since all of the others are generated uniformly.This would skew the mean of the dice rolls higher than the true mean, hence loading the dice.