Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.7] Change CGO_ENABLED to 1 / Changed TLS Version to 1.2 #62

Merged
merged 2 commits into from
Jul 5, 2023
Merged

[release-2.7] Change CGO_ENABLED to 1 / Changed TLS Version to 1.2 #62

merged 2 commits into from
Jul 5, 2023

Conversation

dislbenn
Copy link

@dislbenn dislbenn commented Jul 5, 2023

Changes: Changes the CGO_ENABLED flag to 1 / Changes TLS Version to 1.2.

@dislbenn
Change CGO_ENABLED to 1 / Changed TLS Version to 1.2
d7aad36 
Signed-off-by: Disaiah Bennett <dbennett@redhat.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 5, 2023
View reviewed changes
internal/cortex/chunk/encoding/factory.go Outdated
return err
}

_, ok := encodings[Encoding(i)]

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type uint8 without an upper bound check.
internal/cortex/chunk/encoding/factory.go Outdated
return fmt.Errorf("invalid chunk encoding: %s", s)
}

*e = Encoding(i)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type uint8 without an upper bound check.
@dislbenn dislbenn changed the base branch from main to release-2.7 July 5, 2023 15:46
@dislbenn
updated busybox versions
02aca87 
Signed-off-by: Disaiah Bennett <dbennett@redhat.com>
@openshift-ci openshift-ci bot added the approved label Jul 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ngraham20
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, ngraham20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1615d32 into release-2.7 Jul 5, 2023
3 checks passed
@openshift-merge-robot openshift-merge-robot deleted the fips-update-release-2.7 branch July 5, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subbarao-meduri subbarao-meduri Awaiting requested review from subbarao-meduri

@ngraham20 ngraham20 Awaiting requested review from ngraham20

Assignees

@ngraham20 ngraham20

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dislbenn @ngraham20 @openshift-merge-robot