Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: update deps #30

Merged
merged 2 commits into from
Jan 5, 2022
Merged

fix!: update deps #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b437393
fix: update deps
vasco-santos Dec 29, 2021
15b7d84
chore: use v2 in readme example
vasco-santos Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .dockerignore
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions Dockerfile
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
## Example usage

```yaml
uses: web3-storage/add-to-web3@v1
uses: web3-storage/add-to-web3@v2
id: web3
with:
web3_token: ${{ secrets.WEB3_STORAGE_TOKEN }}
Expand Down Expand Up @@ -64,8 +64,6 @@ e.g. `https://dweb.link/ipfs/bafkreicysg23kiwv34eg2d7qweipxwosdo2py4ldv42nbaugul

💌 Considerate contributions welcome!

*Of note* This is supposed to be a Javascript flavour GitHub Action, but the JS runner is [stuck on node12](https://github.com/actions/runner/issues/772v), and we need at least node14. Until the glorious future where the current node version is supported, we wrap the action in a container.

The `dist` folder is commited to the repo as is the curious cultural norm with JS actions, as the repo is the delivery mechanism, so to spare some cycles for the user users, all the deps are bundled into a single /dist/index.js monolith. This no longer makes much sense as we're also wrapping it in a container, but the dream is that the new node16 runner lands, and we can just delete the Dockers and move on.
The `dist` folder is commited to the repo as is the curious cultural norm with JS actions, as the repo is the delivery mechanism, so to spare some cycles for the user users, all the deps are bundled into a single /dist/index.js monolith.

<h3 align="center"><a href="https://web3.storage">⁂</a></h3>
8 changes: 2 additions & 6 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,5 @@ outputs:
cid:
description: 'The IPFS Content ID for the directory'
runs:
# TODO: we need node14.14 minimum.
# https://github.com/actions/runner/issues/772
# using: 'node12'
# main: 'dist/index.js'
using: 'docker'
image: 'Dockerfile'
using: 'node16'
main: 'dist/index.js'
Loading