Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't enforce optional parameters to be required #41

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix: don't enforce optional parameters to be required #41

merged 1 commit into from
Feb 7, 2022

Conversation

ljmf00
Copy link
Contributor

@ljmf00 ljmf00 commented Jan 18, 2022

Signed-off-by: Luís Ferreira contact@lsferreira.net

Fix #40 .

@ljmf00
fix: don't enforce optional parameters to be required
cd7594c 
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
yusefnapora
yusefnapora approved these changes Feb 7, 2022
View reviewed changes
Copy link

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yusefnapora yusefnapora merged commit 77b645f into storacha:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusefnapora yusefnapora yusefnapora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Action reports optional parameters as required
2 participants
@ljmf00 @yusefnapora