feat: serialization format #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
approved these changes
Jul 14, 2023
2 tasks
This was referenced Jul 17, 2023
vasco-santos
added a commit
to storacha/specs
that referenced
this pull request
Jul 18, 2023
Renames `size` to `height` for `piece`/`aggregate` based on described in storacha/data-segment#13 Note that: - given `piece` and `aggregate` are both perfect binary trees, leaf count of can be derived as `2 ** height`, and the size of the tree can be derived by `leafCount * Node.Size` (32).
vasco-santos
added a commit
to storacha/w3up
that referenced
this pull request
Jul 25, 2023
…together with client and api (#831) Renames `size` to `height` for `piece`/`aggregate` based on described in storacha/data-segment#13 Note that: - took the opportunity to update this to finally rely on `data-segment` lib as it is now ready to be used (both in tests, and to validate aggregate) - given `piece` and `aggregate` are both perfect binary trees, leaf count of can be derived as `2 ** height`, and the size of the tree can be derived by `leafCount * Node.Size` (32). Needs storacha/specs#66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates piece and aggregate serialization format from
{ link, size }to{ link, height }. This allows need for bigints that are problematic in JSON. Since both are perfect binary trees, leaf count of can be derived as2 ** height, and the size of the tree can be derived byleafCount * Node.Size(32).Additionally I've also added bit more code to make piece encode / decode easy, which will need to do quite a bit.