feat: provider spec revamp #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis
requested changes
Jan 26, 2024
There was a problem hiding this comment.
Protocol makes sense to me! Looking forward to moving us fully over to it, this is much clearer than our current system, imho. Lots of copy editing here and a few requests for clarification, but I think this is generally good to ship once the copy editing is incorporated.
Gozala
commented
Jan 31, 2024
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Gozala
commented
Jan 31, 2024
Gozala
commented
Jan 31, 2024
Gozala
commented
Jan 31, 2024
hannahhoward
added a commit
that referenced
this pull request
Sep 4, 2024
This reverts commit 8108999.
Merged
hannahhoward
added a commit
that referenced
this pull request
Oct 4, 2024
# Goals This PR reverts #107 Why? The spec currently diverges wildly from the implementation, and there are no immediate plans to implement the revised version. We can absolutely return to this once we have immediate plans for implementation. Generally, the specs should match exactly the implementation, or there should be notes as to why. I don't know the history and rationale for the revamp, but for now, it's a huge source of confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.