Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the EIPFS infra for the blob protocol #361

Merged
merged 11 commits into from
Apr 29, 2024
Merged

feat: add the EIPFS infra for the blob protocol #361

merged 11 commits into from
Apr 29, 2024

Conversation

joaosa
Copy link
Contributor

@joaosa joaosa commented Apr 29, 2024 •
edited
Loading

  • adds the EIPFS multihashes queue;
  • adds the EIPFS blocks CAR positions table.

@joaosa joaosa force-pushed the feat/expose-blob-protocol-infra branch from dd9e7d5 to 8be72e7 Compare April 29, 2024 14:21
@joaosa joaosa force-pushed the feat/expose-blob-protocol-infra branch from 8be72e7 to 7e63fa2 Compare April 29, 2024 14:27
@seed-deploy Seed Deploy
Copy link

seed-deploy bot commented Apr 29, 2024

View stack outputs

alanshaw
alanshaw requested changes Apr 29, 2024
View reviewed changes
.env.tpl Outdated
@@ -13,6 +13,8 @@

EIPFS_INDEXER_SQS_ARN = 'arn:aws:sqs:us-west-2:505595374361:staging-ep-indexer-topic'
EIPFS_INDEXER_SQS_URL = 'https://sqs.us-west-2.amazonaws.com/505595374361/staging-ep-indexer-topic'
EIPFS_MULTIHASHES_SQS_ARN = 'arn:aws:sqs:us-west-2:505595374361:multihashes-topic'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "staging-multihashes-topic"?

Copy link
Contributor Author

@joaosa joaosa Apr 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT no, so we maybe we should create it.

my bad. found it!

stacks/upload-api-stack.js
@@ -89,6 +116,7 @@ export function UploadApiStack({ stack, app }) {
PIECE_TABLE_NAME: pieceTable.tableName,
PIECE_OFFER_QUEUE_URL: pieceOfferQueue.queueUrl,
FILECOIN_SUBMIT_QUEUE_URL: filecoinSubmitQueue.queueUrl,
BLOCKS_CAR_POSITION_TABLE_NAME: blocksCarPositionTable.tableName,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the multihashes queue URL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright wasn't sure about that one 👍 . adding it

@seed-deploy seed-deploy bot temporarily deployed to pr361 April 29, 2024 15:36 Inactive
alanshaw
alanshaw approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect, thanks!

vasco-santos
vasco-santos approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can you please set these env vars in seed.run?

@joaosa
Copy link
Contributor Author

joaosa commented Apr 29, 2024 •
edited
Loading

LGTM Can you please set these env vars in seed.run?

Only missing production. Adding those

done!

@joaosa joaosa merged commit bb21369 into main Apr 29, 2024
3 checks passed
@joaosa joaosa deleted the feat/expose-blob-protocol-infra branch April 29, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

@vasco-santos vasco-santos vasco-santos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joaosa @alanshaw @vasco-santos