Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add preact import #425

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: re-add preact import #425

merged 1 commit into from
Oct 2, 2024

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Oct 2, 2024

Looks like this was removed here https://github.com/storacha/w3infra/pull/417/files#diff-fe7ebd5c64b7ab6a78e2a72d2c708860905cc2b4591b564ebe7e5d1b4a7d5d4cL5 - not sure why linting didn't pick this up.

Fixes:

ReferenceError: preact is not defined
  File "/var/task/upload-api/functions/validate-email.mjs", line 111928, col 7, in Object.ValidateEmail
    preact.createElement("stripe-pricing-table", {
  File "/var/task/upload-api/functions/validate-email.mjs", line 111380, col 52, in j
    U2.__d = false, b15 && b15(t15), P5 = Z2.call(U2, F7, M4);
  File "/var/task/upload-api/functions/validate-email.mjs", line 111313, col 15, in S
    var s16 = j15(n16, o16 || E6, false, void 0, c16, false, i17);
  File "/var/task/upload-api/functions/validate-email.mjs", line 111865, col 39, in new HtmlResponse
    const stringBody = buildDocument2(P4(body));
  File "/var/task/upload-api/functions/validate-email.mjs", line 112970, col 5, in validateEmailPost
    new html.HtmlResponse(
  File "node:internal/process/task_queues", line 95, col 5, in process.processTicksAndRejections
  File "/var/task/upload-api/functions/validate-email.mjs", line 75415, col 14, in processResult
    rv = await asyncHandler(event, context);

@alanshaw alanshaw requested review from travis and Peeja October 2, 2024 09:26
@seed-deploy seed-deploy bot temporarily deployed to pr425 October 2, 2024 09:26 Inactive
@alanshaw alanshaw mentioned this pull request Oct 2, 2024
@alanshaw alanshaw merged commit 8382280 into main Oct 2, 2024
1 of 3 checks passed
@alanshaw alanshaw deleted the fix/re-add-preact-import branch October 2, 2024 09:38
Copy link

seed-deploy bot commented Oct 2, 2024

View stack outputs

alanshaw added a commit that referenced this pull request Oct 2, 2024
#425 was not caught because
we're not linting `jsx` files.

I verified that this PR caught the error:

```
/Users/alan/Code/storacha/w3infra/upload-api/html-w3s/index.jsx
  180:13  error  'preact' is not defined  no-undef
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant