chore: address review comments

storacha · Oct 25, 2023 · 651955d · 651955d
1 parent 762f9f4
commit 651955d
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/packages/upload-client/src/index.js b/packages/upload-client/src/index.js
@@ -13,7 +13,6 @@ export { Store, Upload, UnixFS, CAR }
 export * from './sharding.js'
 
 const CONCURRENT_REQUESTS = 3
-const PIECE_MULTIHASH_SIZE = PieceHasher.prefix.length + 1 + PieceHasher.size
 
 /**
  * Uploads a file to the service and returns the root data CID for the
@@ -130,12 +129,11 @@ async function uploadBlockStream(conf, blocks, options = {}) {
           Store.add(conf, bytes, options),
           (async () => {
             const hasher = PieceHasher.create()
-            const digestBytes = new Uint8Array(PIECE_MULTIHASH_SIZE)
+            const digestBytes = new Uint8Array(64)
             hasher.write(bytes)
-            hasher.digestInto(digestBytes, 0, true)
-            // TODO: should we?
-            // hasher.free()
-            const digest = Digest.decode(digestBytes)
+            const end = hasher.digestInto(digestBytes, 0, true)
+            const digest = Digest.decode(digestBytes.subarray(0, end))
+            hasher.free()
             return /** @type {import('@web3-storage/capabilities/types').PieceLink} */ (
               Link.create(raw.code, digest)
             )