chore: no longer depends on hd-scripts, packages use/configure eslint directly, fixes warnings from npm lint script #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
force-pushed
the
access-no-hd-scripts
branch
from
540aa04
to
c84ee62
Compare
gobengo
commented
Nov 1, 2023
gobengo
changed the title
travis
approved these changes
Nov 2, 2023
This was referenced Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Tactics:
packages/eslint-config-w3upeslintConfig.extendsto@web3-storage/eslint-config-w3upand have a devDep on that package within the monorepo. No monorepo subpackages use any eslint rules other than those in eslint-config-w3up. i.e. all w3up packages use the same eslint config (this wasn't actually the case before, since different w3up packages were depending on different versions of hd-scripts)