Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "plan/create-admin-session" capability #1411

Merged
merged 13 commits into from
May 13, 2024

Conversation

travis
Copy link
Contributor

@travis travis commented Apr 25, 2024

Our billing system has an external admin customer portal system and their API lets us generate sessions for it on demand - add a capability that will let our customers delegate this ability the email address that is responsible for paying the bills.

See storacha/console#98 for an example of this in action.

@travis travis marked this pull request as draft April 25, 2024 23:53
travis added 3 commits May 7, 2024 12:04
rework capabilities.plan a bit to match the other clients in the same directory
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I was out of the loop, am assuming we decided this capability even though it may not be supported with future billing providers.

LGTM! could we please add some docs though?

@@ -9,6 +9,7 @@

## About


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add to the client the new methods folks can use for plans?

packages/w3up-client/test/helpers/mocks.js Outdated Show resolved Hide resolved
@travis travis merged commit 50eeeb5 into main May 13, 2024
14 checks passed
@travis travis deleted the feat/create-billing-admin-session branch May 13, 2024 23:51
travis pushed a commit that referenced this pull request May 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[17.1.0](capabilities-v17.0.0...capabilities-v17.1.0)
(2024-05-14)


### Features

* add "plan/create-admin-session" capability
([#1411](#1411))
([50eeeb5](50eeeb5))
* add blob protocol to upload-client
([#1425](#1425))
([49aef56](49aef56))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
travis added a commit that referenced this pull request May 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[18.4.0](access-v18.3.2...access-v18.4.0)
(2024-05-14)


### Features

* add "plan/create-admin-session" capability
([#1411](#1411))
([50eeeb5](50eeeb5))
* add blob protocol to upload-client
([#1425](#1425))
([49aef56](49aef56))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
travis added a commit that referenced this pull request May 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[13.1.0](w3up-client-v13.0.1...w3up-client-v13.1.0)
(2024-05-14)


### Features

* add "plan/create-admin-session" capability
([#1411](#1411))
([50eeeb5](50eeeb5))
* add blob protocol to upload-client
([#1425](#1425))
([49aef56](49aef56))


### Fixes

* test against actual api
([#1438](#1438))
([f8132ca](f8132ca))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
travis added a commit that referenced this pull request May 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[14.0.0](upload-api-v13.0.2...upload-api-v14.0.0)
(2024-05-14)


### ⚠ BREAKING CHANGES

* deprecate issuer
([#1344](#1344))

### Features

* add "plan/create-admin-session" capability
([#1411](#1411))
([50eeeb5](50eeeb5))
* add blob protocol to upload-client
([#1425](#1425))
([49aef56](49aef56))
* deprecate issuer
([#1344](#1344))
([afbbde3](afbbde3))
* move blob index logic from upload-api to blob-index lib
([#1434](#1434))
([797f628](797f628))
* remove issuer row
([#1345](#1345))
([cf5b0db](cf5b0db))


### Fixes

* `encodeURIComponent` on bucket origin
([#1448](#1448))
([5618644](5618644))
* add format specifier to blob location claim URL
([#1445](#1445))
([9982d12](9982d12))
* test against actual api
([#1438](#1438))
([f8132ca](f8132ca))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants