Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable docs task on release #1499

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Jun 6, 2024

This hasn't been working for a long time now and I don't think we even use the docs it generates.

contains(fromJson(needs.release.outputs.paths_released), 'packages/filecoin-api') ||
contains(fromJson(needs.release.outputs.paths_released), 'packages/w3up-client')
uses: './.github/workflows/reusable-deploy-docs.yml'
# docs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be cleaner to delete it? One can always restore from history if needed

@alanshaw alanshaw requested a review from joaosa June 6, 2024 12:40
Copy link
Contributor

@joaosa joaosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanshaw alanshaw merged commit b4e4b43 into main Jun 6, 2024
1 check passed
@alanshaw alanshaw deleted the chore/disable-docs-task-on-release branch June 6, 2024 12:59
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants