Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for Node.js 20 #840

Merged
merged 2 commits into from
Jul 25, 2023
Merged

fix: support for Node.js 20 #840

merged 2 commits into from
Jul 25, 2023

Conversation

alanshaw
Copy link
Member

Support Node.js 20 in the clients.

Adds a temporary fix for Node.js 20 as blob.stream() is currently broken: nodejs/node#48916

Also adds matrix config to CI workflows so that tests are run in both node 18 & 20.

Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeesh

@alanshaw alanshaw merged commit 93e4d61 into main Jul 25, 2023
9 checks passed
@alanshaw alanshaw deleted the fix/nodejs20-support branch July 25, 2023 11:53
alanshaw pushed a commit that referenced this pull request Jul 25, 2023
🤖 I have created a release *beep* *boop*
---


##
[9.1.1](upload-client-v9.1.0...upload-client-v9.1.1)
(2023-07-25)


### Bug Fixes

* support for Node.js 20
([#840](#840))
([93e4d61](93e4d61))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants