fix: use the issuer as the resource in revocation #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the space DID as the resource, which works in the default case but falls apart when re-delegating access to someone else's space, as a user would be attempting to revoke a resource they did not have ucan/revoke capabilities on.
travis
force-pushed
the
fix/revoke-resource
branch
from
92e2f3b
to
84634ea
Compare
Gozala
approved these changes
Oct 27, 2023
gobengo
pushed a commit
that referenced
this pull request
Nov 1, 2023
🤖 I have created a release *beep* *boop* --- ## [16.4.0](access-v16.3.0...access-v16.4.0) (2023-11-01) ### Features * access agent proofs method would fail to return some session proofs ([#1047](#1047)) ([d23a1c9](d23a1c9)) ### Bug Fixes * use the issuer as the resource in revocation ([#992](#992)) ([7346d1f](7346d1f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the space DID as the resource, which works in the default case but falls apart when re-delegating access to someone else's space, as a user would be attempting to revoke a resource they did not have
ucan/revokecapabilities on.