fix: upgrade fr32-sha2-256-trunc-254-padded-binary-tree-multihash #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/upgrade-fr32-sha2-256-lib
branch
from
3b129f2
to
2974d19
Compare
vasco-santos
force-pushed
the
fix/upgrade-fr32-sha2-256-lib
branch
from
2974d19
to
762f9f4
Compare
Gozala
reviewed
Oct 25, 2023
packages/upload-client/src/index.js
Outdated
| @@ -13,7 +13,7 @@ export { Store, Upload, UnixFS, CAR } | |||
| export * from './sharding.js' | |||
|
|
|||
| const CONCURRENT_REQUESTS = 3 | |||
| const PIECE_MULTIHASH_SIZE = PieceHasher.prefix.length + PieceHasher.size | |||
| const PIECE_MULTIHASH_SIZE = PieceHasher.prefix.length + 1 + PieceHasher.size | |||
There was a problem hiding this comment.
This is no longer correct as size will vary based on padding applied.
|
@vasco-santos I think error occurs because of the buffer overflow, that is supplied Uint8Array is smaller than amount of bytes been written into it. I'll test that hypothesis and will see if I can make tests case for fr32...hash to improve error messages. |
Gozala
reviewed
Oct 25, 2023
packages/upload-client/src/index.js
Outdated
| @@ -133,6 +133,8 @@ async function uploadBlockStream(conf, blocks, options = {}) { | |||
| const digestBytes = new Uint8Array(PIECE_MULTIHASH_SIZE) | |||
| hasher.write(bytes) | |||
| hasher.digestInto(digestBytes, 0, true) | |||
| // TODO: should we? | |||
| // hasher.free() | |||
There was a problem hiding this comment.
Yeah calling free will allow memory used by WASM to be reclaimed
Gozala
approved these changes
Oct 26, 2023
Gozala
approved these changes
Oct 26, 2023
vasco-santos
force-pushed
the
fix/upgrade-fr32-sha2-256-lib
branch
from
e4a8ba9
to
c14fce3
Compare
forgot to update lock file 😓 |
vasco-santos
pushed a commit
that referenced
this pull request
Oct 27, 2023
🤖 I have created a release *beep* *boop* --- ## [11.0.0](upload-client-v10.1.0...upload-client-v11.0.0) (2023-10-27) ### ⚠ BREAKING CHANGES * filecoin client to use new capabilities * filecoin capabilities ### Bug Fixes * add missing ContentNotFound definition for filecoin offer failure ([c0b97bf](c0b97bf)) * add missing filecoin submit success and failure types ([c0b97bf](c0b97bf)) * client tests ([b0d9c3f](b0d9c3f)) * fix arethetypesworking errors in all packages ([#1004](#1004)) ([2e2936a](2e2936a)) * package.json files excludes 'src' and includes .js and .js.map in dist for packages that now export their module from dist ([#1012](#1012)) ([d2537de](d2537de)) * type errors ([c0b97bf](c0b97bf)) * upgrade fr32-sha2-256-trunc-254-padded-binary-tree-multihash ([#997](#997)) ([f6828ec](f6828ec)) ### Code Refactoring * filecoin capabilities ([c0b97bf](c0b97bf)) * filecoin client to use new capabilities ([b0d9c3f](b0d9c3f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades lib in
upload-clientto use PieceCidv2