UI to apply data extents #5
Conversation
… for stacked series vislib tests
| <div class="vis-option-item"> | ||
| <label> | ||
| <input type="checkbox" value="{{defaultYExtents}}" ng-model="vis.params.defaultYExtents" name="defaultYExtents" ng-checked="vis.params.defaultYExtents"> | ||
| Set y axis to data extents |
There was a problem hiding this comment.
We probably need new verbage here. Perhaps having a conversation with @w33ble or @spenceralger.
There was a problem hiding this comment.
Maybe we should turn it around: by default it is checked and says something like "always show axis origin"?
You're right Shelby, we need to find a better description for this option. Perhaps it can wait for now though.
|
Need to add a test for this. |
…tests to line and column
|
I think this is ready to merge... Let me know |
| @@ -0,0 +1,7 @@ | |||
| <vislib-basic-options></vislib-basic-options> | |||
| <div class="vis-option-item"> | |||
There was a problem hiding this comment.
With all the copy and paste, I think it makes sense to add this to the vislib-basic-options directive ☝️
|
@jthomassie want to make the changes that @spenceralger suggested. Then I can take a look at it and merge it. |
|
This is ready to merge. Then I think we should have a discussion in Kibana room about the UI wording and behavior. |
|
LGTM |
display info about missing object
fixed windows issue in kibana.bat for spaces in path
Create shrinkwrap from build
Added simple UI checkbox to apply data extents to the y scale.
Note: data extents are automatically applied when data has pos and neg values.
The checkbox makes visible change to y scale and chart when data values are all pos or all neg by changing the min or max from 0 to the data extent.