Fix LinkWrapper props to avoid collisions w React, Gatsby, etc links #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesuss
changed the title
kylesuss
changed the title
tmeasday
reviewed
Jun 7, 2019
src/components/Link.js
Outdated
| delete linkWrapperProps.inverse; | ||
| delete linkWrapperProps.nochrome; | ||
| delete linkWrapperProps.secondary; | ||
| delete linkWrapperProps.tertiary; |
There was a problem hiding this comment.
I think a more idiomatic way to do this is:
const { inverse, nochrome, secondary, tertiary, ...linkWrapperProps } = rest;
return <StyledLinkWrapper {...linkWrapperProps}>{content}</StyledLinkWrapper>;There was a problem hiding this comment.
Love it. It's funny, I am so used to using that pattern when destructuring in function params, but it felt weird in this context. Makes sense, good eye :)
Updated!
kylesuss
force-pushed
the
fix-lint-wrapper-props
branch
from
addd86d
to
6191f55
Compare
|
🚀 PR was released in v0.0.21 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix this in an earlier PR, but I didn't get it right. I think I have it now -- A lot of the
Linkcomponents that you use w/ other libs like Gatsby & React Router complain when you pass them props that are not standard. I kept seeing errors for this in the console:I decided to just manually delete the props from the prop object that is passed down to the
LinkWrapper-- that seemed to do the trick.