Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded to 5.3beta and added dependencies plugin #125

Merged
merged 8 commits into from
Jan 27, 2020

Conversation

atanasster
Copy link
Member

  • upgraded to storybook 5.3 beta
  • added dependencies plugin

I was testing the dependencies plugin and made those changes anyway,
No problem at all if you don't want to upgrade to 5.3 beta yet, or if the dependencies plugin is not desired.

@shilman
Copy link
Member

shilman commented Nov 30, 2019

@atanasster the current design takes up a lot of screen real estate:

Design_System___Avatar_-_Large_⋅_Storybook

how about merging both of these tables into a single table and using "sections" within the table to differentiate between dependencies & dependents:

InfoButton_-_Simple_⋅_Storybook

i think this would be considerably more compact and look better too!

@atanasster
Copy link
Member Author

thanks @shilman great suggestion, the new table Sections look great. I have updated the plugin and bumped the package version:

grab14

@shilman
Copy link
Member

shilman commented Dec 1, 2019

@atanasster nice use of presets 👨‍🍳💋👌

@atanasster
Copy link
Member Author

Thanks @ndelangen had suggested to use presets.
I updated the readme now also for a quick setup: https://github.com/atanasster/storybook-addon-deps

@domyen
Copy link
Member

domyen commented Jan 21, 2020

@atanasster now that the dust has settled on 5.3. Want to pick this back up? I'd love to link to SDS as an example of the dependency addon in your deps blog post.

@atanasster
Copy link
Member Author

@domyen - done :)

@domyen
Copy link
Member

domyen commented Jan 22, 2020

@atanasster There are some merge conflicts, can you take another look?

@atanasster
Copy link
Member Author

@domyen - I think I solved those merge conflicts, although merging is not my forte so crossing fingers :)

@domyen
Copy link
Member

domyen commented Jan 23, 2020

Nice thanks! @ndelangen we're getting a new error on this branch with the Chromatic GH Action that says we need an app code. AFAICT we have a secret for this that's referenced in the workflow file. Could you sanity check our configuration?

@ndelangen
Copy link
Member

it's from a fork, thus the secret isn't shared.

I'll open a PR making the app-code public asap

@ndelangen
Copy link
Member

Please merge in master, to get the public app_code in this PR

@atanasster
Copy link
Member Author

@ndelangen - is this me merging or @domyen merging?

@ndelangen
Copy link
Member

Me I guess 🌞

@domyen
Copy link
Member

domyen commented Jan 27, 2020

Dope, this looks awesome!

@domyen domyen merged commit 1d063ad into storybookjs:master Jan 27, 2020
@ghengeveld
Copy link
Member

🚀 PR was released in v4.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants