Minor refinements to codesnippet #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesuss
reviewed
Aug 10, 2020
| padding: 15px 1rem; | ||
| padding-right: 5rem; | ||
| padding: 1em 1em 1.5em; | ||
| padding-right: 2em; |
There was a problem hiding this comment.
The point of this was to make it so that you could scroll all the way right & not have the "Copy" button overlaying any of the code. So long as you are aware that removing this will break that, I am ok w/ it. Maybe the argument is that you can see it when you are scrolled left?
There was a problem hiding this comment.
The internal padding shouldn't trigger the scrollbar unnecessarily.
afaict the scrollbar appears below the content so it doesn't affect the content or the copy functionality.
There was a problem hiding this comment.
The internal padding shouldn't trigger the scrollbar unnecessarily.
That's fair, though it has the potential to overlap slightly:
kylesuss
reviewed
Aug 10, 2020
|
🚀 PR was released in v5.1.19 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.