Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Tooltip onClick duplication #52

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Remove Tooltip onClick duplication #52

merged 1 commit into from
Jul 2, 2019

Conversation

kylesuss
Copy link
Collaborator

@kylesuss kylesuss commented Jul 2, 2019 •
edited
Loading

toggleTooltipShown was being called twice as we were manually passing an onClick to the tooltip trigger and the react-popper-tooltip library was also calling the toggle function as a result of the onVisibilityChange prop.

I just remove our manual onClick handler and it appears to be unnecessary.

Closes #51

@kylesuss kylesuss requested a review from domyen July 2, 2019 17:52
@kylesuss kylesuss merged commit 69bdf43 into master Jul 2, 2019
@kylesuss kylesuss deleted the fix-tooltip-onclick-dup branch July 2, 2019 17:57
@kylesuss
Copy link
Collaborator Author

kylesuss commented Jul 2, 2019

🚀 PR was released in v0.0.39 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domyen domyen domyen approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip with trigger="click" behavior
2 participants
@kylesuss @domyen