Apply link styles to LinkWrapper #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesuss
commented
Jun 4, 2019
| return ( | ||
| <a href={href} {...rest} onClick={modifiedOnClick}> | ||
| {children} | ||
| </a> |
There was a problem hiding this comment.
I updated this to better simulate what a GatsbyLink (or React Router link for that matter) would return
|
@domyen if you merge this, can you let me push the version bump plz? There is a weird thing that I have to do just for this 1 version bump as I made a bit of a mess when I fixed the release process. It won't be an issue after that. |
kylesuss
force-pushed
the
fix-link-wrapper
branch
from
c0aed77
to
270a39b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the last 2 (previously the text link had no styling):