Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Highlight for consumption #9

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Export Highlight for consumption #9

merged 1 commit into from
Jun 6, 2019

Conversation

kylesuss
Copy link
Collaborator

@kylesuss kylesuss commented Jun 6, 2019

Missed this last time -- I thought all the components were exported automatically.

@domyen domyen merged commit 4666dc7 into master Jun 6, 2019
@domyen domyen deleted the fix-highlight-export branch June 6, 2019 21:58
@kylesuss
Copy link
Collaborator Author

kylesuss commented Jun 6, 2019

🚀 PR was released in v0.0.20 🚀

@shilman
Copy link
Member

shilman commented Jun 7, 2019

@kylesuss Can we use named exports to keep things consistent? Easier to track through the code 😘

@kylesuss
Copy link
Collaborator Author

kylesuss commented Jun 7, 2019 •
edited
Loading

@shilman Sure! To clarify, are you suggesting that even if there will only ever be 1 export for a file, that we still only export it as a named export?

Edit: Updated here: 0fb5605

@shilman
Copy link
Member

shilman commented Jun 7, 2019

Thanks!! 🙇 That's the one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

@domyen domyen Awaiting requested review from domyen

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylesuss @shilman @domyen