Replace custom colors/typography stories with DocBlocks. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylesuss
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
Thanks for your patience @leerob while I tried to see if I could sort out the naming issue after the Storybook upgrade. Sounds like we should just push forward with what you have here and not try to override the story names. I think I like that better anyhow, less boilerplate!
The docs pages you added look great! Only suggestion I can make is to consider adding the altered opacity states for the colors per Dom's description:
In the design the opacity scale is 100%, 80%, 60%, 30%.
That said, it doesn't need to happen in this PR. I will go ahead and merge this so we can close it out. Thanks for the effort!
|
🚀 PR was released in v1.1.7 🚀 |
|
Woohoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #84.
Overview
With official MDX support coming soon, we want to update the design system to reflect the new hotness. This PR updates the custom colors/typography stories to use MDX along with the corresponding DocBlocks.
Examples