Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] React 17 support #121

Closed
mtmacdonald opened this issue Nov 5, 2020 · 12 comments
Closed

[Bug] React 17 support #121

mtmacdonald opened this issue Nov 5, 2020 · 12 comments
Labels

Comments

@mtmacdonald
Copy link

Hi! Can we please have React 17 support so I don't get this peer dependency warning upon npm install in my React 17 projects. Thanks!

npm WARN react-inspector@5.1.0 requires a peer of react@^16.8.4 but none is installed. You must install peer dependencies yourself.

@pip8786
Copy link

pip8786 commented Feb 5, 2021

It seems to be updated in the package.json but not published. Is there any way to get published?

@jackric
Copy link

jackric commented Feb 8, 2021

Please publish a patch release! I am current required to install deps with $ npm install --legacy-peer-deps without this.

@pd8
Copy link

pd8 commented Feb 17, 2021

Hi I was wondering if this version had been released already - I can see the code in your main branch but it doesn't look like a new version has been published yet. This would unblock part of the storybook 6.1 react 17 support for npm 7, so was hoping we'd see a new version soon, I can see @bcomnes merged the change... hello again from reach/router#452 ! I was wondering who manages the releases?

@kevinwolfcr
Copy link

This is also causing projects with npm@>7.x installs. Is there a chance this could be released soon?

@siiiiilvio
Copy link

🚢 🙏

@silltho
Copy link

silltho commented Mar 15, 2021

@ndelangen am i right that this is blocked by reach/router#452? If not is there anything the community could do to get this released?

@ndelangen
Copy link
Member

@silltho I invited you to the github org, if you could help out getting this repo is a better shape, that'd be amazing.

If you'd like to also publish new version no npm, let's have a quick chat via the storybook discord:
https://discord.gg/js3AjMg6dW

@bcomnes
Copy link
Collaborator

bcomnes commented Apr 1, 2021

@ndelangen I reached out on discord to help out. @Hypnosphi is already a contributor and has been helpful to get a bunch of the other packages over the line. Perhaps consider giving him publishing permissions. I'm also willing to help with that if nobody else is.

@bcomnes
Copy link
Collaborator

bcomnes commented Apr 2, 2021

Ok, I have contribution access and will get a new release out to fix this.

@thomasboyt
Copy link

Hi, is anything preventing a release of 5.1.1? Currently working around this bug with npm install --legacy-peer-deps but rather awkward to make sure that's used everywhere.

@silltho
Copy link

silltho commented Apr 15, 2021

@thomasboyt you can use a .npmrc file in the root of your project with legacy-peer-deps=true to set the flag.

@bcomnes
Copy link
Collaborator

bcomnes commented Apr 15, 2021

Ok react-inspector 5.1.1 supports react 17. Sorry for the wait. It looks like reach router is the last thing holding off react 17 support:

reach/router#452

@bcomnes bcomnes closed this as completed Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants